From 8ab1e1e1fab29567fae768142ffa2f755f14c820 Mon Sep 17 00:00:00 2001 From: Erica Z Date: Sat, 2 Nov 2024 18:25:26 +0100 Subject: [PATCH] enable mpv verbose logging --- src/mpv.rs | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mpv.rs b/src/mpv.rs index 178ade5..1b830bd 100644 --- a/src/mpv.rs +++ b/src/mpv.rs @@ -86,6 +86,9 @@ impl Handle { ); } + // set up verbose logging for now + Error::from_return_code(unsafe { ffi::mpv_request_log_messages(inner.as_ptr(), c"v".as_ptr()) }).unwrap(); + // TODO: maybe we need to set something before initialization, but idk // also wed need a builder, since "Note that you should avoid doing concurrent accesses on the uninitialized client handle." Error::from_return_code(unsafe { ffi::mpv_initialize(inner.as_ptr()) }) @@ -116,6 +119,15 @@ impl Handle { match event.event_id { ffi::mpv_event_id_MPV_EVENT_NONE => break, + ffi::mpv_event_id_MPV_EVENT_LOG_MESSAGE => { + let data = unsafe { &*(event.data as *mut ffi::mpv_event_log_message) }; + // TODO: actual logging? + let prefix = unsafe { CStr::from_ptr(data.prefix) }.to_str().unwrap(); + let level = unsafe { CStr::from_ptr(data.level) }.to_str().unwrap(); + let text = unsafe { CStr::from_ptr(data.text) }.to_str().unwrap(); + print!("[{prefix}] {level}: {text}"); + }, + 11 => { /* deprecated, ignore */ } _ => todo!("event {}", event.event_id), @@ -134,8 +146,9 @@ impl Handle { impl Drop for Handle { fn drop(&mut self) { - // destroy? terminate_destroy?? - todo!() + unsafe { + ffi::mpv_destroy(self.inner.as_ptr()); + } } }