From 79f0e3d97882f5cc9e41ad20de7513b946637bce Mon Sep 17 00:00:00 2001 From: Erica Z Date: Tue, 19 Nov 2024 18:59:22 +0100 Subject: [PATCH] document that --- src/subsonic.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/subsonic.rs b/src/subsonic.rs index c59babf..988e18d 100644 --- a/src/subsonic.rs +++ b/src/subsonic.rs @@ -204,6 +204,11 @@ impl Client { }) } + // this Result is only an error if the main loop future was cancelled + // therefore it's safe to just drop it + // note that in general its fine not to cancel the tokio task when its corresponding + // mainloop task is dropped, since eg for song thumbnails there's already a semaphore + // limiting concurrent requests let _ = sender.send(perform(future.await).await).await; });