zerica/audrey
1
1
Fork 0
Code Issues 3 Pull requests Projects Releases Packages Wiki Activity Actions

dont actually use random_bytes, it leaks memory

Browse source 
ha ha vala what the fuck
This commit is contained in:
Erica Z 2024-10-16 00:07:19 +02:00
parent 9e05dc3313
commit 086ab02f77
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/ui/setup.vala
View file

@ -101,7 +101,8 @@ public class Ui.Setup : Adw.PreferencesDialog {
private void salt_password (string password, out string token, out string salt) { private void salt_password (string password, out string token, out string salt) {
const int SALT_BYTES = 8; const int SALT_BYTES = 8;
uchar salt_bytes[SALT_BYTES] = GCrypt.Random.random_bytes (SALT_BYTES); uchar salt_bytes[SALT_BYTES];
GCrypt.Random.randomize (salt_bytes);
uchar salt_chars[2*SALT_BYTES+1]; uchar salt_chars[2*SALT_BYTES+1];
for (int i = 0; i < SALT_BYTES; i += 1) { for (int i = 0; i < SALT_BYTES; i += 1) {
salt_chars[2*i+0] = "0123456789abcdef"[(salt_bytes[i]>>4)&0xf]; salt_chars[2*i+0] = "0123456789abcdef"[(salt_bytes[i]>>4)&0xf];